This repository has been archived by the owner on Oct 6, 2020. It is now read-only.
fix(Formbot): Set field value before validating in onChange handler #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
=======================================
Coverage 74.21% 74.21%
=======================================
Files 13 13
Lines 159 159
Branches 24 24
=======================================
Hits 118 118
Misses 30 30
Partials 11 11Continue to review full report at Codecov.
|
erikshestopal
approved these changes
Jan 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous logic would invalidate the field, losing the scope of the synthetic onChange event handler in the valdiation promise. After validation, Formbot would then set the new values, causing Input cursor to jump to the end.