-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
One discussion item is how much markdown is supported? Since the initial thought was just links. |
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
==========================================
- Coverage 74.21% 67.97% -6.24%
==========================================
Files 13 13
Lines 159 178 +19
Branches 24 27 +3
==========================================
+ Hits 118 121 +3
- Misses 30 42 +12
- Partials 11 15 +4
Continue to review full report at Codecov.
|
@sappira-inc/engineering |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might as well add a snapshot for markdown rendering and then this is g2g from me
@choochootrain Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
not sure about the node types we want to allow but i the skipHtml
prop should lock out most of the sketchy parts
@kylealwyn is there a use case for nesting the |
Summary:
Adds markdown support. I've experimented with several solutions so far and
react-markdown
got me closest to what I was trying to accomplish. Withreact-markdown
the links are still parsed as before as well as the additional markdown.Still a WIP.