This repository has been archived by the owner on Oct 6, 2020. It is now read-only.
fix: Fix button padding and font sizes #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikshestopal
requested review from
albertovillalobos,
kylealwyn,
alextranwork,
a team and
choochootrain
gerrymi
approved these changes
May 21, 2020
albertovillalobos
approved these changes
May 21, 2020
|
@erikshestopal I'm seeing several UI changes on chromatic, where there no snapshot updates anywhere? 🤔 |
|
@albertovillalobos didn't see any snapshot changes. I even ran the tests locally 😆 |
|
@erikshestopal weird that chromatic is asking for review for all of them, strange. It looks good tho, I'll look chromatic later, this branch good to go! 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates button padding and the
smvariant font-size to match our Figma design system. This was a request from Jay when we were doing a live QA bug bash.Before
After
