Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix source map of modules beyond entry #5

Closed
wants to merge 1 commit into from

Conversation

xania
Copy link

@xania xania commented Feb 4, 2023

Description

This small update fixes source map of modules beyond entry files. I am on windows machine but I dont belief it matters in this case.
Url's at this point start with '/' which is not valid in ssr mode, causing an error in VSCode:

[UriError]: If a URI does not contain an authority component, then the path cannot begin with two slash characters ("//")

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red
Copy link
Owner

sapphi-red commented Apr 21, 2023

@xania Do you have a reproduction? I want to check what is wrong here.

@xania
Copy link
Author

xania commented Apr 25, 2023

@xania Do you have a reproduction? I want to check what is wrong here.

It seems like it's fixed in this branch. I tried to reproduce it a clean empty project and also in my day to day project but likely could not find any issues.

@xania xania closed this Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants