Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code fields save a string #12

Open
groenroos opened this issue Oct 30, 2021 · 0 comments
Open

Code fields save a string #12

groenroos opened this issue Oct 30, 2021 · 0 comments
Assignees
Labels
bug Unintended behaviour and security vulnerabilities help wanted Issues where help is needed from other contributors

Comments

@groenroos
Copy link
Member

In the Configuration UI, the "code" field currently saves the object as a string, which is obviously not correct.

Even getting the code editor to work properly thus far took some doing. Feels like the vue-prism-editor is quite fragile, and as it can't take an object as a value, there needs to be some parsing to ensure any field with a code editor first stringifies its content for the editor, and then parses it into an object for saving. All the while making sure these transformations do not trigger reactivity. Also, only Vuex knows which fields are code fields, but the Configuration state needs to stay outside of Vuex to make sure changes aren't visible throughout the UI before they are saved. And some kind of validation might also be useful.

@groenroos groenroos added bug Unintended behaviour and security vulnerabilities help wanted Issues where help is needed from other contributors labels Oct 30, 2021
@groenroos groenroos self-assigned this Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unintended behaviour and security vulnerabilities help wanted Issues where help is needed from other contributors
Development

No branches or pull requests

1 participant