fix(structure): use correct loading messages while resolving panes #6093
+26
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While the structure panes are resolving (when using async resolvers), we show one or more loading messages. It starts with a "Loading..." message, shown after X ms. Later, after X seconds, it is supposed to show a "Still loading..." followed by a "Check if there's something wrong with your structure definition" kind of thing.
This code path has been broken for a while now, it seems:
This PR fixes both of these cases.
What to review
child
structure resolver that waits for 10+s before returning the child nodeTesting
I've added a workshop story for this. Ideally I'd also add automated tests, but seems like we're missing some established tests in the structure codebase that I can base them off of.
Notes for release