Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use PKG_VERSION from @sanity/pkg-utils instead of manually regexing SANITY_VERSION #6078

Merged
merged 2 commits into from
Mar 20, 2024
Merged

refactor: use PKG_VERSION from @sanity/pkg-utils instead of manually regexing SANITY_VERSION #6078

merged 2 commits into from
Mar 20, 2024
+5 −102

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented Mar 20, 2024

No description provided.

@stipsan stipsan requested a review from a team as a code owner March 20, 2024 10:51
@stipsan stipsan requested review from rexxars and removed request for a team March 20, 2024 10:51
@vercel Vercel
Copy link

vercel bot commented Mar 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Mar 20, 2024 5:04pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 5:04pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Mar 20, 2024 5:04pm

@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 20, 2024 •
edited
Loading

Component Testing Report Updated Mar 20, 2024 5:13 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 34s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 1s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 0s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 11s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 24s 8 0 1

@stipsan stipsan force-pushed the add-SANITY_VERSION-to-turbo-global-env branch from 727b441 to e2c7bee Compare March 20, 2024 11:08
@stipsan stipsan changed the title chore: add SANITY_VERSION to turbo globalEnv refactor: use PKG_VERSION from @sanity/pkg-utils instead of manually regexing SANITY_VERSION Mar 20, 2024
bjoerge
bjoerge approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you sir <3

@socket-security Socket Security
Copy link

socket-security bot commented Mar 20, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

View full report↗︎

@bjoerge bjoerge force-pushed the add-SANITY_VERSION-to-turbo-global-env branch from 7b4b8a0 to e2c7bee Compare March 20, 2024 15:27
@bjoerge bjoerge mentioned this pull request Mar 20, 2024
Merged
@binoy14 binoy14 added this pull request to the merge queue Mar 20, 2024
Merged via the queue into next with commit d514bfc Mar 20, 2024
36 checks passed
@binoy14 binoy14 deleted the add-SANITY_VERSION-to-turbo-global-env branch March 20, 2024 17:14
hermanwikner pushed a commit that referenced this pull request Mar 21, 2024
@stipsan @bjoerge @hermanwikner
refactor: use PKG_VERSION from @sanity/pkg-utils instead of manua…
fa717ab 
…lly regexing `SANITY_VERSION` (#6078)

* refactor: use `PKG_VERSION` from `@sanity/pkg-utils` instead of manually regexing `SANITY_VERSION`

* chore(sanity): remove unused script (#6090)

---------

Co-authored-by: Bjørge Næss <[email protected]>
hermanwikner pushed a commit that referenced this pull request Mar 21, 2024
@stipsan @bjoerge @hermanwikner
refactor: use PKG_VERSION from @sanity/pkg-utils instead of manua…
a3c6736 
…lly regexing `SANITY_VERSION` (#6078)

* refactor: use `PKG_VERSION` from `@sanity/pkg-utils` instead of manually regexing `SANITY_VERSION`

* chore(sanity): remove unused script (#6090)

---------

Co-authored-by: Bjørge Næss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoerge bjoerge bjoerge approved these changes

@rexxars rexxars rexxars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stipsan @rexxars @bjoerge @binoy14