Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comments): hide context menu actions if handler is undefined #6011

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

hermanwikner
Copy link
Member

Description

This pull request ensures that the "resolve" and "copy link" items are hidden from a comment item's context menu if no handler is provided for them. This change is implemented because, within the Tasks feature, these actions are currently rendered but lack functionality.

What to review

  • Verify that only the appropriate actions are displayed in the context menu

Notes for release

N/A

@hermanwikner hermanwikner requested review from a team, skogsmaskin and pedrobonamin and removed request for a team March 15, 2024 11:46
Copy link

vercel bot commented Mar 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Mar 18, 2024 9:37am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2024 9:37am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2024 9:37am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Mar 15, 2024

Component Testing Report Updated Mar 18, 2024 9:42 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 11s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 13s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 33s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 59s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 3s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 21s 9 0 0

@hermanwikner hermanwikner added this pull request to the merge queue Mar 18, 2024
Merged via the queue into next with commit cb55bc5 Mar 18, 2024
34 of 36 checks passed
@hermanwikner hermanwikner deleted the edx-1195 branch March 18, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants