chore(comments): add support for comments layout avatar config #5944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobonamin
requested review from
a team,
skogsmaskin and
hermanwikner
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
3 tasks
|
No changes to documentation |
|
Component Testing Report Updated Mar 11, 2024 11:30 AM (UTC)
|
packages/sanity/src/structure/comments/src/components/list/CommentsListItemLayout.tsx
Outdated
Show resolved
Hide resolved
packages/sanity/src/structure/comments/src/components/list/CommentsListItem.tsx
Outdated
Show resolved
Hide resolved
packages/sanity/src/structure/comments/src/components/list/CommentsListItem.tsx
Outdated
Show resolved
Hide resolved
pedrobonamin
force-pushed
the
edx-1142
branch
5 times, most recently
from
398a1bf to
1e96825
Compare
| @@ -325,7 +344,7 @@ export function CommentsListItemLayout(props: CommentsListItemLayoutProps) { | |||
| > | |||
| <InnerStack space={1} data-muted={displayError}> | |||
| <Flex align="center" gap={FLEX_GAP} flex={1}> | |||
There was a problem hiding this comment.
When the parent comment does not have an avatar, the spacing between the author name and the comment message is a bit off (see image). To address this, I suggest creating a styled component of this Flex – like HeaderFlex – which has a min height of 25px.
const HeaderFlex = styled(Flex)`
min-height: ${AVATAR_HEIGHT};
` Before and after:
There was a problem hiding this comment.
Good catch, updated it to use the avatar size prop.
The height of the avatar will be variable, e.g. if size is 0 it will be 19px.
ninaandal
pushed a commit
that referenced
this pull request
Mar 12, 2024
* chore(comments): add support for comments layout avatar config * chore(comments): remove show prop from SpacerAvatar * fix(comments): nitpicks * fix(comments): add min height to the comment list item header
juice49
pushed a commit
that referenced
this pull request
Mar 13, 2024
* chore(comments): add support for comments layout avatar config * chore(comments): remove show prop from SpacerAvatar * fix(comments): nitpicks * fix(comments): add min height to the comment list item header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for avatar config in comments layout.
Supports building the UI needed for tasks.
Notice how the avatar size is reduced and also removed from the parent comment.
What to review
Testing
Notes for release