Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(comments): use _weak instead of weak #5936

Merged
merged 1 commit into from
Mar 8, 2024
Merged

fix(comments): use _weak instead of weak #5936

merged 1 commit into from
Mar 8, 2024

Conversation

hermanwikner
Copy link
Member

Description

What to review

Testing

Notes for release

@hermanwikner hermanwikner requested review from a team and jtpetty and removed request for a team March 8, 2024 14:20
@vercel Vercel
Copy link

vercel bot commented Mar 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
performance-studio 🔄 Building (Inspect) Visit Preview Mar 8, 2024 2:20pm
test-studio 🔄 Building (Inspect) Visit Preview Mar 8, 2024 2:20pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Mar 8, 2024 2:20pm

@hermanwikner hermanwikner added this pull request to the merge queue Mar 8, 2024
Merged via the queue into next with commit 642224f Mar 8, 2024
19 of 21 checks passed
@hermanwikner hermanwikner deleted the fix/comments-weak branch March 8, 2024 14:22
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Component Testing Report Updated Mar 8, 2024 2:29 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 13s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 1s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 2s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 20s 9 0 0

juice49 pushed a commit that referenced this pull request Mar 13, 2024
@hermanwikner @juice49
fix(comments): use _weak instead of weak (#5936)
43007b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobonamin pedrobonamin pedrobonamin approved these changes

@jtpetty jtpetty Awaiting requested review from jtpetty

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hermanwikner @pedrobonamin