-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add groups to document actions, introduce paneActions group #5933
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
No changes to documentation |
Component Testing Report Updated Mar 10, 2024 11:35 AM (UTC)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! Just found a few smaller things that would be good to fix before merging.
packages/sanity/src/core/components/hookCollection/GetHookCollectionState.tsx
Show resolved
Hide resolved
packages/sanity/src/structure/panes/document/documentPanel/header/DocumentPanelHeader.tsx
Outdated
Show resolved
Hide resolved
packages/sanity/src/structure/panes/document/statusBar/ActionMenuButton.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work @pedrobonamin
…up (#5933) * feat(core): add groups to document actions, introduce paneActions group * fix(core): update GetHookCollectionState types
…up (#5933) * feat(core): add groups to document actions, introduce paneActions group * fix(core): update GetHookCollectionState types
Description
Introduces
groups
into DocumentActions allowing plugin developers to add actions and decide where they want this actions to show:default
will add the actions to the same position as before, in the footer right next to the publish button.paneActions
will add the action in the context menu right next to the inspectors and other pane actions.This is initially intended to support creating
tasks
from within a document.Example of usage
Screen.Recording.2024-03-08.at.10.39.52.mov
What to review
Is there other way to simplify this?
Are the changes in
GetHookCollectionState
correct?Testing
Create an action from within a plugin, the action should render in the selected group.
Notes for release
Add support for groups in document actions.