fix(comments): enable check #5918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermanwikner
requested review from
pedrobonamin and
ricokahler
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
hermanwikner
commented
Mar 6, 2024
| @@ -37,29 +41,22 @@ export function useFeatureEnabled(featureKey: string): Features { | |||
| const {projectId} = useSource() | |||
|
|
|||
| if (!cachedFeatureRequest.get(projectId)) { | |||
| const features = fetchFeatures({versionedClient}).pipe( | |||
| shareReplay(), | |||
| catchError((error) => { | |||
There was a problem hiding this comment.
Removing the error catch here so that we can catch it below instead.
|
No changes to documentation |
|
Component Testing Report Updated Mar 6, 2024 3:49 PM (UTC)
|
pedrobonamin
approved these changes
Mar 7, 2024
juice49
pushed a commit
that referenced
this pull request
Mar 13, 2024
* feat(core): add `error` to `useFeatureEnabled` * fix(comments): only enable comments if we are able to fetch project features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request ensures that we only display the upsell UI or the comments UI if we can successfully fetch the feature flags for the current project. If fetching the feature flags is not possible, for example, due to the current user's permissions restricting access to "project details," we cannot accurately determine which UI to display. Therefore, in such scenarios, we must disable the feature entirely to prevent inadvertently showing the upsell UI for a project where it is actually enabled.
What to review
studioCommentsNotes for release
N/A