Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(comments): enable inline comments #5883

Merged
merged 3 commits into from
Mar 6, 2024
Merged

chore(comments): enable inline comments #5883

merged 3 commits into from
Mar 6, 2024

Conversation

skogsmaskin
Copy link
Member

@skogsmaskin skogsmaskin commented Mar 1, 2024 •
edited by hermanwikner
Loading

Description

This pull request enables the inline comments feature and the e2e test for it.

What to review

  • Make sure that inline comments is enabled

Notes for release

N/A

@vercel Vercel
Copy link

vercel bot commented Mar 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Mar 6, 2024 2:53pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 2:53pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2024 2:53pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 1, 2024 •
edited
Loading

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 1, 2024 •
edited
Loading

Component Testing Report Updated Mar 6, 2024 2:55 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 0s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 0s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 11s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 19s 9 0 0

@skogsmaskin skogsmaskin force-pushed the chore/enable-inline-comments branch from c0250b9 to 36784c8 Compare March 4, 2024 14:13
@skogsmaskin skogsmaskin force-pushed the chore/enable-inline-comments branch 2 times, most recently from 39bbd56 to 4eccbb4 Compare March 4, 2024 14:34
@hermanwikner hermanwikner force-pushed the chore/enable-inline-comments branch from 4eccbb4 to cd61602 Compare March 6, 2024 14:44
@hermanwikner hermanwikner marked this pull request as ready for review March 6, 2024 14:50
@hermanwikner hermanwikner requested a review from a team March 6, 2024 14:50
@hermanwikner hermanwikner requested a review from a team as a code owner March 6, 2024 14:50
@hermanwikner hermanwikner requested review from hermanwikner and rexxars and removed request for a team March 6, 2024 14:50
@hermanwikner hermanwikner removed the request for review from rexxars March 6, 2024 14:51
jtpetty
jtpetty approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@jtpetty jtpetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@hermanwikner hermanwikner added this pull request to the merge queue Mar 6, 2024
Merged via the queue into next with commit 7d3f33d Mar 6, 2024
40 checks passed
@hermanwikner hermanwikner deleted the chore/enable-inline-comments branch March 6, 2024 15:12
juice49 pushed a commit that referenced this pull request Mar 13, 2024
@skogsmaskin @hermanwikner @juice49
chore(comments): enable inline comments (#5883)
1a88c19 
* chore(comments): enable inline comments

* fix(comments): remove comment in plugin

* test(comments): remove comment in e2e test

---------

Co-authored-by: Herman Wikner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hermanwikner hermanwikner hermanwikner approved these changes

@jtpetty jtpetty jtpetty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skogsmaskin @jtpetty @hermanwikner