Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): add successful document restoration string #5821

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

juice49
Copy link
Contributor

@juice49 juice49 commented Feb 23, 2024

Description

There is no language string for the restore event, which causes the generic toast message to be rendered with a missing {{context}} value:

Screenshot 2024-02-22 at 16 50 34

This change adds a dedicated string for successful document restoration:

Screenshot 2024-02-23 at 09 48 38

What to review

  • Is the string okay?

Testing

I don't believe we test document operation toasts at the moment, so it wouldn't make sense to implement just for document restoration.

@juice49 juice49 requested a review from a team as a code owner February 23, 2024 09:51
@juice49 juice49 requested review from ricokahler and removed request for a team February 23, 2024 09:51
Copy link

vercel bot commented Feb 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Feb 23, 2024 4:45pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 4:45pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Feb 23, 2024 4:45pm

@juice49 juice49 requested a review from a team February 23, 2024 09:51
Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Feb 23, 2024

Component Testing Report Updated Feb 23, 2024 4:50 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 22s 0 0 3
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 13s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 59s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 1s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 19s 9 0 0

@juice49 juice49 force-pushed the fix/sdx-1117-document-restoration-toast branch from ea63adc to 95ee812 Compare February 23, 2024 16:41
@juice49 juice49 added this pull request to the merge queue Feb 23, 2024
Merged via the queue into next with commit 21677cd Feb 23, 2024
39 of 40 checks passed
@juice49 juice49 deleted the fix/sdx-1117-document-restoration-toast branch February 23, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants