Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(portable-text-editor): new API method getFragment #5806

Merged
merged 2 commits into from
Feb 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -280,4 +280,8 @@ export class PortableTextEditor extends Component<PortableTextEditorProps> {
debug(`Host toggling mark`, mark)
editor.editable?.toggleMark(mark)
}
static getFragment = (editor: PortableTextEditor): PortableTextBlock[] | undefined => {
debug(`Host getting fragment`)
return editor.editable?.getFragment()
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,142 @@
import {describe, expect, it, jest} from '@jest/globals'
import {isPortableTextTextBlock} from '@sanity/types'
import {render, waitFor} from '@testing-library/react'
import {createRef, type RefObject} from 'react'

import {PortableTextEditorTester, schemaType} from '../../__tests__/PortableTextEditorTester'
import {PortableTextEditor} from '../../PortableTextEditor'

const initialValue = [
{
_key: 'a',
_type: 'myTestBlockType',
children: [
{
_key: 'a1',
_type: 'span',
marks: [],
text: 'Block A',
},
],
markDefs: [],
style: 'normal',
},
{
_key: 'b',
_type: 'myTestBlockType',
children: [
{
_key: 'b1',
_type: 'span',
marks: [],
text: 'Block B ',
},
{
_key: 'b2',
_type: 'someObject',
},
{
_key: 'b3',
_type: 'span',
marks: [],
text: ' contains a inline object',
},
],
markDefs: [],
style: 'normal',
},
]

describe('plugin:withEditableAPI: .getFragment()', () => {
it('can get a Portable Text fragment of the current selection in a single block', async () => {
const editorRef: RefObject<PortableTextEditor> = createRef()
const onChange = jest.fn()
render(
<PortableTextEditorTester
onChange={onChange}
ref={editorRef}
schemaType={schemaType}
value={initialValue}
/>,
)
const initialSelection = {
focus: {path: [{_key: 'a'}, 'children', {_key: 'a1'}], offset: 6},
anchor: {path: [{_key: 'a'}, 'children', {_key: 'a1'}], offset: 7},
}
await waitFor(() => {
if (editorRef.current) {
PortableTextEditor.focus(editorRef.current)
PortableTextEditor.select(editorRef.current, initialSelection)
const fragment = PortableTextEditor.getFragment(editorRef.current)
expect(
fragment && isPortableTextTextBlock(fragment[0]) && fragment[0]?.children[0]?.text,
).toBe('A')
}
})
})
it('can get a Portable Text fragment of the current selection in multiple blocks', async () => {
const editorRef: RefObject<PortableTextEditor> = createRef()
const onChange = jest.fn()
render(
<PortableTextEditorTester
onChange={onChange}
ref={editorRef}
schemaType={schemaType}
value={initialValue}
/>,
)
const initialSelection = {
anchor: {path: [{_key: 'a'}, 'children', {_key: 'a1'}], offset: 6},
focus: {path: [{_key: 'b'}, 'children', {_key: 'b3'}], offset: 9},
}
await waitFor(() => {
if (editorRef.current) {
PortableTextEditor.focus(editorRef.current)
PortableTextEditor.select(editorRef.current, initialSelection)
const fragment = PortableTextEditor.getFragment(editorRef.current)
expect(fragment).toMatchInlineSnapshot(`
Array [
Object {
"_key": "a",
"_type": "myTestBlockType",
"children": Array [
Object {
"_key": "a1",
"_type": "span",
"marks": Array [],
"text": "A",
},
],
"markDefs": Array [],
"style": "normal",
},
Object {
"_key": "b",
"_type": "myTestBlockType",
"children": Array [
Object {
"_key": "b1",
"_type": "span",
"marks": Array [],
"text": "Block B ",
},
Object {
"_key": "b2",
"_type": "someObject",
},
Object {
"_key": "b3",
"_type": "span",
"marks": Array [],
"text": " contains",
},
],
"markDefs": Array [],
"style": "normal",
},
]
`)
}
})
})
})
Original file line number Diff line number Diff line change
Expand Up @@ -512,6 +512,9 @@ export function createWithEditableAPI(
editor.insertBreak()
editor.onChange()
},
getFragment: () => {
return fromSlateValue(editor.getFragment(), types.block.name)
},
})
return editor
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ export interface EditableAPI {
focusBlock: () => PortableTextBlock | undefined
focusChild: () => PortableTextChild | undefined
getSelection: () => EditorSelection
getFragment: () => PortableTextBlock[] | undefined
getValue: () => PortableTextBlock[] | undefined
hasBlockStyle: (style: string) => boolean
hasListStyle: (listStyle: string) => boolean
Expand Down
Loading