Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comments): catch and suppress errors from comments upsell #5700

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Feb 8, 2024

Fixes #5697

Notes for release

  • Fixed an issue where a comments-related request could trigger an uncaught error dialog being displayed

@rexxars rexxars requested review from binoy14, a team and skogsmaskin and removed request for a team February 8, 2024 20:12
Copy link

vercel bot commented Feb 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Feb 8, 2024 8:15pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2024 8:15pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Feb 8, 2024 8:15pm

Copy link
Contributor

github-actions bot commented Feb 8, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented Feb 8, 2024

Component Testing Report Updated Feb 8, 2024 8:20 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 33s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 18s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 1s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 20s 9 0 0

Copy link
Contributor

@binoy14 binoy14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Contributor

@pedrobonamin pedrobonamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @rexxars . Will consider it for next ones !

@rexxars rexxars added this pull request to the merge queue Feb 8, 2024
Merged via the queue into next with commit fbaffd2 Feb 8, 2024
40 checks passed
@rexxars rexxars deleted the fix/upsell-error-handler branch February 8, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comments API CORS Error After update
3 participants