Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(telemetry): add telemetry for Trial Dialogs #5643

Merged
merged 9 commits into from
Feb 13, 2024
Merged

Conversation

drewlyton
Copy link
Contributor

@drewlyton drewlyton commented Feb 1, 2024

Description

Adds view and activity telemetry for Dialogs and Popovers related to the Growth Trial. Equivalent PR in Manage: https://github.com/sanity-io/manage/pull/429

What to review

The areas affected are isolated to the FreeTrial components - including the FreeTrialProvider. The code also adds a new .telemetry file for defining the Trial-related events.

There is also some work done to pass query parameters from the URL bar to the personalization-forge service calls (i.e. /journey/trial). This allows us to more easily test the look and behavior of each of the dialogs without needing a project to be in that specific trial state.

Testing

To test this PR, you can inspect the network calls while using the trialState and seenBefore query parameters for showing different sets of dialogs. You should see the telemetry logs appear in the batch call every 30 seconds.

param values
trialState growth-trial, growth-trial-ending, post-growth-trial
seenBefore true, false

Little video explaining how the query params work:

Screen.Recording.2024-02-01.at.3.34.12.PM.mov

Notes for release

🤷‍♂️ Not sure if we need to specify in release notes that we've added these new events?

Copy link

vercel bot commented Feb 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Feb 13, 2024 2:13pm
studio-workshop 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 13, 2024 2:13pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2024 2:13pm

Copy link
Contributor

github-actions bot commented Feb 1, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented Feb 1, 2024

Component Testing Report Updated Feb 13, 2024 2:16 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 35s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 13s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 33s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 18s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 1s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 21s 9 0 0

Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment/question. Not a blocker for merge, but consider if you think it's worth doing

@juice49 juice49 added this pull request to the merge queue Feb 13, 2024
Merged via the queue into next with commit ad971f8 Feb 13, 2024
40 checks passed
@juice49 juice49 deleted the feat/gro-1460 branch February 13, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants