-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(telemetry): add telemetry for Trial Dialogs #5643
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
No changes to documentation |
Component Testing Report Updated Feb 13, 2024 2:16 PM (UTC)
|
drewlyton
force-pushed
the
feat/gro-1460
branch
from
February 2, 2024 16:36
2ca56cc
to
313be5f
Compare
drewlyton
changed the title
Add telemetry for Trial Dialogs
feat(telemetry) add telemetry for Trial Dialogs
Feb 5, 2024
drewlyton
changed the title
feat(telemetry) add telemetry for Trial Dialogs
feat(telemetry): add telemetry for Trial Dialogs
Feb 5, 2024
drewlyton
force-pushed
the
feat/gro-1460
branch
from
February 5, 2024 16:28
84933da
to
33ad208
Compare
drewlyton
requested review from
a team and
pedrobonamin
and removed request for
a team
February 5, 2024 16:28
bjoerge
reviewed
Feb 7, 2024
...ty/src/core/studio/components/navbar/free-trial/__telemetry__/trialDialogEvents.telemetry.ts
Outdated
Show resolved
Hide resolved
...ty/src/core/studio/components/navbar/free-trial/__telemetry__/trialDialogEvents.telemetry.ts
Outdated
Show resolved
Hide resolved
...ty/src/core/studio/components/navbar/free-trial/__telemetry__/trialDialogEvents.telemetry.ts
Outdated
Show resolved
Hide resolved
...ty/src/core/studio/components/navbar/free-trial/__telemetry__/trialDialogEvents.telemetry.ts
Outdated
Show resolved
Hide resolved
...ty/src/core/studio/components/navbar/free-trial/__telemetry__/trialDialogEvents.telemetry.ts
Outdated
Show resolved
Hide resolved
...ty/src/core/studio/components/navbar/free-trial/__telemetry__/trialDialogEvents.telemetry.ts
Outdated
Show resolved
Hide resolved
packages/sanity/src/core/studio/components/navbar/free-trial/DialogContent.tsx
Outdated
Show resolved
Hide resolved
drewlyton
force-pushed
the
feat/gro-1460
branch
from
February 8, 2024 15:50
33ad208
to
deadff2
Compare
bjoerge
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment/question. Not a blocker for merge, but consider if you think it's worth doing
...ty/src/core/studio/components/navbar/free-trial/__telemetry__/trialDialogEvents.telemetry.ts
Outdated
Show resolved
Hide resolved
drewlyton
force-pushed
the
feat/gro-1460
branch
from
February 12, 2024 16:34
7658673
to
9269662
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds view and activity telemetry for Dialogs and Popovers related to the Growth Trial. Equivalent PR in Manage: https://github.com/sanity-io/manage/pull/429
What to review
The areas affected are isolated to the FreeTrial components - including the FreeTrialProvider. The code also adds a new
.telemetry
file for defining the Trial-related events.There is also some work done to pass query parameters from the URL bar to the
personalization-forge
service calls (i.e./journey/trial
). This allows us to more easily test the look and behavior of each of the dialogs without needing a project to be in that specific trial state.Testing
To test this PR, you can inspect the network calls while using the
trialState
andseenBefore
query parameters for showing different sets of dialogs. You should see the telemetry logs appear in thebatch
call every 30 seconds.trialState
growth-trial
,growth-trial-ending
,post-growth-trial
seenBefore
true
,false
Little video explaining how the query params work:
Screen.Recording.2024-02-01.at.3.34.12.PM.mov
Notes for release
🤷♂️ Not sure if we need to specify in release notes that we've added these new events?