fix(cli): add support for import.meta.env
#5617
Merged
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Full Report@sanity/migrate
@sanity/diff
@sanity/block-tools
@sanity/types
sanity/desk
@sanity/portable-text-editor
@sanity/mutator
@sanity/cli
@sanity/util/legacyDateFormat
@sanity/schema/_internal
@sanity/util/paths
sanity/router
@sanity/schema
sanity/structure
sanity/cli
@sanity/vision
@sanity/util/fs
sanity/_internal
@sanity/util/createSafeJsonParser
sanity/_internalBrowser
@sanity/util/content
sanity
|
|
Component Testing Report Updated Jan 30, 2024 9:14 PM (UTC)
|
|
Eh may not be the best idea to release this without properly populating |
ricokahler
changed the title
import.meta.envimport.meta.env
rexxars
approved these changes
Jan 30, 2024
rexxars
reviewed
Jan 30, 2024
Comment on lines
+39
to
+40
| // define the `process.env` global | ||
| ...getStudioEnvironmentVariables({prefix: 'process.env.', jsonEncode: true}), |
There was a problem hiding this comment.
Not actually sure if this one is needed, given we're already in an environment with process.env defined - maybe if the .env files and such is not already loaded?
There was a problem hiding this comment.
added as a safety mechanism, since process.env is not a browser thing right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following adds minimal support for
import.meta.envinside of the mock browser environment used in the CLI.What to review
Does it work?
Testing
I added an import.meta.env usage in the test-studio and ran the command.
Notes for release
import.meta.envto break the mock browser environment used in the CLI.