test(migration) add tests for normalizeMigrationDefinition

[binoy14]

Description

Adds test for normalizeMigrationDefinition function

What to review

Not 100% sure if it makes sense and is testing the full capability of the functions, @bjoerge thoughts?

Testing

Added :)

Notes for release

N/A

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
performance-studio	❌ Failed (Inspect)			Feb 1, 2024 10:50pm
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 1, 2024 10:50pm

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Feb 1, 2024 10:50pm

[github-actions]

No changes to documentation

[github-actions]

Component Testing Report Updated Feb 1, 2024 10:54 PM (UTC)

File	Status	Duration	Passed	Skipped	Failed
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	32s	15	0	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	6s	3	0	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	13s	3	0	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	13s	4	2	0
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	13s	6	0	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	33s	15	0	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	18s	9	0	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	1m 1s	18	0	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	14s	6	0	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	20s	9	0	0

[binoy14]

Current dependencies on/for this PR:

• next
  • PR feat: migration runner #5540
    • PR feat(cli): improve reporting when dry running from export #5609
    • PR feat(cli): add pretty mutation formatting to migration runner #5573
    • PR feat(migrate): add bufferThroughFile utility #5572
    • PR chore(migration): add better error message when request fails #5567
    • PR feat(migration): support passing an array of documentTypes to migration #5566
    • PR feat(migration): support async hooks in migration nodes #5564
      • PR test(migration) add tests for normalizeMigrationDefinition #5565 👈
    • PR feat(migrate): use safe JSON parser when streaming from Export HTTP API #5542
    • PR feat(migrate): implement mutation batcher #5541
      • PR feat(migrate): limit mutate request concurrency #5544
        • PR feat(migration): improve progress as migration is running #5550
          • PR feat(migration): add a prompt before runing a real migration #5552

This stack of pull requests is managed by Graphite.

[bjoerge]

I think it would be nice to assert a couple of more cases:

• Calling the normalized function of node migration hooks resolves to a list of the returned mutations
• Returning nothing/void from an async node migration doesn't include undefined in the final list of mutations

[jtpetty]

is this test just testing that we follow an interface?

[binoy14]

for the most part it just ensures that it is returns an iterable. normalizeMigrateDefinition internally calls this function so the above tests do actually test most of it's functionality