chore(deps): various cleanups and dependency fixes #5534

bjoerge · 2024-01-21T21:59:46Z

Description

Various deps and tooling cleanups required by upcoming yarn => pnpm work

What to review

Testing

Notes for release

n/a - internal

vercel · 2024-01-21T21:59:48Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
performance-studio	✅ Ready (Inspect)	Visit Preview		Feb 14, 2024 9:00am
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 14, 2024 9:00am

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Feb 14, 2024 9:00am

bjoerge · 2024-01-21T22:00:01Z

Current dependencies on/for this PR:

next
- PR chore(eslint): add rules to enforce consistent type imports and deterministic import orders #5531
  - PR chore(deps): various cleanups and dependency fixes #5534 👈
    - PR chore(test): move to jest globals #5532
      - PR chore: use pnpm as package manager #5533

This stack of pull requests is managed by Graphite.

socket-security · 2024-01-21T22:01:23Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@sanity/[email protected]	Transitive: environment, network	`+35`	9.53 MB	ricokahler
npm/@sanity/[email protected]	Transitive: environment, network	`+43`	14 MB	ash, atombender, binoy14, ...41 more
npm/@types/[email protected]	None	`+1`	9.33 kB	types
npm/@types/[email protected]	None	`0`	5.68 kB	types
npm/@types/[email protected]	None	`0`	6.27 kB	types
npm/@vitejs/[email protected]	Transitive: environment, eval, filesystem, network, shell, unsafe	`+227`	255 MB	vitebot
npm/[email protected]	filesystem Transitive: environment, shell, unsafe	`+30`	11.8 MB	jounqin
npm/[email protected]	environment, eval, filesystem, network, shell, unsafe	`+77`	228 MB	vitebot

🚮 Removed packages: npm/@types/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

github-actions · 2024-01-21T22:05:04Z

No changes to documentation

github-actions · 2024-01-21T22:08:51Z

Component Testing Report Updated Feb 14, 2024 9:03 AM (UTC)

File	Status	Duration	Passed	Skipped
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	32s	15	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	6s	3	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	12s	3	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	13s	4	2
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	13s	6	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	33s	15	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	18s	9	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	59s	18	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	13s	6	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	19s	9	0

jtpetty · 2024-02-13T15:14:56Z

CONTRIBUTING.md

@@ -27,16 +27,13 @@ yarn dev
 - Rebase your feature branch regularly against `next`. Make sure its even with `next` before merging
 - Once it's done, open a pull request targeting `next`
 - After at least two reviewers has approved the pull request, you can merge it into `next` when you feel ready (if you're on the Sanity team, obviously)
- Everything except minor _trivial_ changes should go through pull-requests. If you're unsure whether it's a trivial change or not, submit a pull request just to be sure


removing pretty quick as it's not compatible with prettier 3.x (checking changed files for formatting errors should be covered by lint-staged already)

This was referenced Jan 21, 2024

chore(test): move to jest globals #5532

Merged

chore: use pnpm as package manager #5533

Merged

vercel bot deployed to Preview – performance-studio January 21, 2024 22:05 View deployment

vercel bot deployed to Preview – test-studio January 21, 2024 22:05 View deployment

bjoerge force-pushed the chore/cleanup branch from b1f0aa0 to faf2416 Compare January 21, 2024 23:32

bjoerge changed the base branch from chore/consistent-imports to next January 21, 2024 23:32

vercel bot deployed to Preview – performance-studio January 21, 2024 23:37 View deployment

vercel bot deployed to Preview – test-studio January 21, 2024 23:38 View deployment

bjoerge force-pushed the chore/cleanup branch from faf2416 to 97e14ef Compare January 22, 2024 00:39

bjoerge changed the base branch from next to chore/consistent-imports January 22, 2024 00:39

bjoerge mentioned this pull request Jan 22, 2024

chore(eslint): add rules to enforce consistent type imports and deterministic import orders #5531

Merged

vercel bot deployed to Preview – performance-studio January 22, 2024 00:43 View deployment

vercel bot deployed to Preview – test-studio January 22, 2024 00:43 View deployment

bjoerge force-pushed the chore/consistent-imports branch from 8495f93 to 1ed75e1 Compare January 22, 2024 01:46

bjoerge force-pushed the chore/cleanup branch from 97e14ef to 73ce92e Compare January 22, 2024 01:46

vercel bot deployed to Preview – performance-studio January 22, 2024 01:46 View deployment

vercel bot deployed to Preview – test-studio January 22, 2024 01:50 View deployment

bjoerge force-pushed the chore/consistent-imports branch from 1ed75e1 to 728c830 Compare January 22, 2024 08:22

bjoerge force-pushed the chore/cleanup branch from 73ce92e to 9b8cb3f Compare January 22, 2024 08:22

vercel bot deployed to Preview – performance-studio January 22, 2024 08:27 View deployment

vercel bot deployed to Preview – test-studio January 22, 2024 08:28 View deployment

bjoerge force-pushed the chore/consistent-imports branch 4 times, most recently from c270c5e to 7df382a Compare February 9, 2024 12:12

vercel bot had a problem deploying to Preview – performance-studio February 13, 2024 12:34 Failure

vercel bot had a problem deploying to Preview – test-studio February 13, 2024 12:34 Failure

bjoerge force-pushed the chore/cleanup branch 2 times, most recently from f341c21 to 59f2ce8 Compare February 13, 2024 12:38

vercel bot deployed to Preview – performance-studio February 13, 2024 12:44 View deployment

bjoerge force-pushed the chore/cleanup branch from 59f2ce8 to e5b35a2 Compare February 13, 2024 12:44

vercel bot deployed to Preview – performance-studio February 13, 2024 12:44 View deployment

vercel bot deployed to Preview – test-studio February 13, 2024 12:45 View deployment

bjoerge requested a review from sjelfull February 13, 2024 13:57

jtpetty reviewed Feb 13, 2024

View reviewed changes

bjoerge force-pushed the chore/cleanup branch from e5b35a2 to cc69902 Compare February 14, 2024 08:42

vercel bot deployed to Preview – performance-studio February 14, 2024 08:48 View deployment

vercel bot deployed to Preview – test-studio February 14, 2024 08:49 View deployment

bjoerge added 11 commits February 14, 2024 09:53

chore(deps): normalize vite dependencies

9f81fbe

chore(docs): remove internal 'how to publish' from CONTRIBUTING.md

54e703f

chore: install npm check-updates as dev dependency

d0eea10

removing pretty quick as it's not compatible with prettier 3.x (checking changed files for formatting errors should be covered by lint-staged already)

chore: upgrade debug to latest 4.x

287397b

chore(depcheck): remove v2 detector and fix ts error

a71d43e

chore(depcheck): cleanup depcheck ignores

a86df0b

chore(portable-text-editor): add missing dev dependency

3162a1b

chore(groq): use relative imports to 'groq' from tests

ce79240

chore(sanity): add missing dev dependencies

2ea9507

chore(cli): cleanup dependencies

0aa752d

fix(test): remove unused files

a438526

bjoerge force-pushed the chore/cleanup branch from cc69902 to a438526 Compare February 14, 2024 08:54

vercel bot deployed to Preview – performance-studio February 14, 2024 08:59 View deployment

vercel bot deployed to Preview – test-studio February 14, 2024 09:00 View deployment

sjelfull approved these changes Feb 14, 2024

View reviewed changes

bjoerge merged commit c973845 into next Feb 14, 2024
41 checks passed

bjoerge deleted the chore/cleanup branch February 14, 2024 09:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): various cleanups and dependency fixes #5534

chore(deps): various cleanups and dependency fixes #5534

bjoerge commented Jan 21, 2024 •

edited

Loading

vercel bot commented Jan 21, 2024 •

edited

Loading

bjoerge commented Jan 21, 2024 •

edited

Loading

socket-security bot commented Jan 21, 2024 •

edited

Loading

github-actions bot commented Jan 21, 2024 •

edited

Loading

github-actions bot commented Jan 21, 2024 •

edited

Loading

jtpetty Feb 13, 2024

chore(deps): various cleanups and dependency fixes #5534

chore(deps): various cleanups and dependency fixes #5534

Conversation

bjoerge commented Jan 21, 2024 • edited Loading

Description

What to review

Testing

Notes for release

vercel bot commented Jan 21, 2024 • edited Loading

bjoerge commented Jan 21, 2024 • edited Loading

socket-security bot commented Jan 21, 2024 • edited Loading

github-actions bot commented Jan 21, 2024 • edited Loading

github-actions bot commented Jan 21, 2024 • edited Loading

jtpetty Feb 13, 2024

Choose a reason for hiding this comment

bjoerge commented Jan 21, 2024 •

edited

Loading

vercel bot commented Jan 21, 2024 •

edited

Loading

bjoerge commented Jan 21, 2024 •

edited

Loading

socket-security bot commented Jan 21, 2024 •

edited

Loading

github-actions bot commented Jan 21, 2024 •

edited

Loading

github-actions bot commented Jan 21, 2024 •

edited

Loading