-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): token
login method session restoration
#5497
Merged
Merged
+61
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
juice49
force-pushed
the
fix/sdx-868-token-hydration
branch
from
January 12, 2024 12:41
8666d69
to
2b2fa8a
Compare
juice49
force-pushed
the
fix/sdx-868-token-hydration
branch
from
January 12, 2024 12:52
2b2fa8a
to
aafa90e
Compare
juice49
changed the title
Fix/sdx 868 token hydration
fix(core): Jan 12, 2024
token
login method session restoration
… to retrieve token from localStorage
juice49
force-pushed
the
fix/sdx-868-token-hydration
branch
from
January 12, 2024 13:01
aafa90e
to
eea2c9c
Compare
Full Report@sanity/diff
@sanity/block-tools
@sanity/types
sanity/desk
@sanity/portable-text-editor
@sanity/mutator
@sanity/cli
@sanity/schema/_internal
@sanity/util/paths
sanity/router
@sanity/util/legacyDateFormat
@sanity/schema
sanity/structure
sanity/cli
@sanity/vision
@sanity/util/fs
sanity/_internal
sanity/_internalBrowser
@sanity/util/content
sanity
|
Component Testing Report Updated Jan 18, 2024 10:59 AM (UTC)
|
rexxars
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fix! Small request for a visibility change.
juice49
added a commit
that referenced
this pull request
Jan 18, 2024
* chore(core): fix typo * feat(core): add login method types * feat(core): add `isCookielessCompatibleLoginMethod` type guard * fix(core): if any cookieless compatible login method is used, attempt to retrieve token from localStorage * chore(core): move `isAuthStore` type guard to new `asserters` module * refactor(core): adjust `CookielessCompatibleLoginMethod` type visibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When initialising
AuthStore
, Studio only attempts to read the cookieless auth token from localStorage if the login method isdual
. If the login method istoken
(e.g. cookie-based auth is explicitly disabled), Studio does not attempt to read the cookieless auth token from localStorage. This means that the active session is not restored when Studio initialises (e.g. when reloading the host webpage after signing in).The fix is quite small. As part of this work, I've also taken care of a few small chores.
What to review
Configure a Studio workspace to authenticate using the
token
method:Sign into the Studio, and then reload the webpage. The active session should be restored (prior to this fix, the user is shown the sign-in UI at this point).
Note that when using the test-studio inside the Sanity monorepo, this issue only occurs in production builds. You can test the production build using the
serve
npm package (npm i -g serve
):Notes for release
Correctly restore the active session when the
token
login method is used.