-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(test): use "runtime": "automatic"
for "@babel/preset-react"
#5492
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Full Report@sanity/diff
@sanity/block-tools
@sanity/types
sanity/desk
@sanity/portable-text-editor
@sanity/mutator
@sanity/cli
@sanity/schema/_internal
@sanity/util/paths
sanity/router
@sanity/util/legacyDateFormat
@sanity/schema
sanity/structure
sanity/cli
@sanity/vision
@sanity/util/fs
sanity/_internal
sanity/_internalBrowser
@sanity/util/content
sanity
|
Component Testing Report Updated Jan 11, 2024 5:57 PM (UTC)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think babel is only used for jest but I could be wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sanity/pkg-utils
already supports automatic insertion of react/jsx
imports by using esbuild.
Adding it in Babel won't break anything, worst case scenario the build when publishing the monorepo might take slightly longer than before, as babel is slower than esbuild.
Description
This PR allows us to use JSX without importing react. Seems like the last thing not to support this was just our jest tests which uses babel to compile on the fly.
Later we should open a PR that removes all unused react imports as well but that can come at a later time.
What to review
Notes for release
N/A