Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add custom resize handle icon #5462

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

robinpyon
Copy link
Contributor

Description

This PR fixes the following issues:

  • custom scrollbars (in browsers that support them) within text fields wouldn't correctly render RHS borders
  • resize handles in text fields (with scroll overflow) would render with an unsightly white box on dark mode

Before (link):

image

After (link):

image

More context:

This is accomplished by rendering a custom SVG (as a Data URI) as a background image. Similar to custom scrollbars, this custom resize handle image is only displayed in webkit browsers.

I don't believe it's possible to accomplish this without a custom image – changing the background color in the ::-webkit-scrollbar-corner selector isn't sufficient, as it'll still render unsightly white borders on both the left and top sides.

What to review

Drag handles in both dark and light modes should look good.

Notes for release

N/A

@robinpyon robinpyon requested a review from a team as a code owner January 5, 2024 21:23
@robinpyon robinpyon requested review from ricokahler and removed request for a team January 5, 2024 21:23
Copy link

vercel bot commented Jan 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Jan 5, 2024 9:23pm
test-studio ✅ Ready (Inspect) Visit Preview Jan 5, 2024 9:23pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Jan 5, 2024 9:23pm

@robinpyon robinpyon requested a review from pedrobonamin January 5, 2024 21:23
Copy link
Contributor

github-actions bot commented Jan 5, 2024

Package Documentation Change
sanity -3%
Full Report
@sanity/diff
This branch Next branch
13 documented 13 documented
16 not documented 16 not documented
@sanity/block-tools
This branch Next branch
4 documented 4 documented
9 not documented 9 not documented
@sanity/types
This branch Next branch
54 documented 54 documented
235 not documented 235 not documented
sanity/desk
This branch Next branch
84 documented 84 documented
64 not documented 64 not documented
@sanity/portable-text-editor
This branch Next branch
21 documented 21 documented
44 not documented 44 not documented
@sanity/mutator
This branch Next branch
7 documented 7 documented
4 not documented 4 not documented
@sanity/cli
This branch Next branch
1 documented 1 documented
31 not documented 31 not documented
@sanity/schema/_internal
This branch Next branch
0 documented 0 documented
12 not documented 12 not documented
@sanity/util/paths
This branch Next branch
1 documented 1 documented
15 not documented 15 not documented
sanity/router
This branch Next branch
17 documented 17 documented
26 not documented 26 not documented
@sanity/util/legacyDateFormat
This branch Next branch
0 documented 0 documented
3 not documented 3 not documented
@sanity/schema
This branch Next branch
0 documented 0 documented
2 not documented 2 not documented
sanity/structure
This branch Next branch
2 documented 2 documented
6 not documented 6 not documented
sanity/cli
This branch Next branch
2 documented 2 documented
0 not documented 0 not documented
@sanity/vision
This branch Next branch
0 documented 0 documented
3 not documented 3 not documented
@sanity/util/fs
This branch Next branch
0 documented 0 documented
3 not documented 3 not documented
sanity/_internal
This branch Next branch
0 documented 0 documented
1 not documented 1 not documented
sanity/_internalBrowser
This branch Next branch
0 documented 0 documented
3 not documented 3 not documented
@sanity/util/content
This branch Next branch
1 documented 1 documented
5 not documented 5 not documented
sanity
This branch Next branch
173 documented 180 documented
841 not documented 849 not documented

Copy link
Contributor

github-actions bot commented Jan 5, 2024

Component Testing Report Updated Jan 5, 2024 9:30 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 33s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 18s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 0s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 15s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 7s 3 0 0

@robinpyon robinpyon added this pull request to the merge queue Jan 8, 2024
Merged via the queue into next with commit 38f951c Jan 8, 2024
38 of 40 checks passed
@robinpyon robinpyon deleted the fix/add-custom-resize-icon branch January 8, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants