Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(block-tools): keep strike-through formatting when pasting from gdocs #5443

Merged
merged 1 commit into from
Jan 4, 2024
Merged

fix(block-tools): keep strike-through formatting when pasting from gdocs #5443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/@sanity/block-tools/src/HtmlDeserializer/rules/gdocs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@ function isUnderline(el: Node): boolean {
return /text-decoration:underline/.test(style || '')
}

// text-decoration seems like the most important rule for strike-through in their html
function isStrikethrough(el: Node): boolean {
const style = isElement(el) && el.getAttribute('style')
return /text-decoration:line-through/.test(style || '')
}

// Check for attribute given by the gdocs preprocessor
function isGoogleDocs(el: Node): boolean {
return isElement(el) && Boolean(el.getAttribute('data-is-google-docs'))
Expand Down Expand Up @@ -100,6 +106,9 @@ export default function createGDocsRules(
if (isUnderline(el)) {
span.marks.push('underline')
}
if (isStrikethrough(el)) {
span.marks.push('strike-through')
}
if (isEmphasis(el)) {
span.marks.push('em')
}
Expand Down
4 changes: 2 additions & 2 deletions packages/@sanity/block-tools/test/tests/HtmlDeserializer/gdocsLists/output.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
"children": [
{
"_type": "span",
"marks": [],
"marks": ["strike-through"],
"text": "Level 2",
"_key": "randomKey40"
}
Expand Down Expand Up @@ -130,7 +130,7 @@
"children": [
{
"_type": "span",
"marks": [],
"marks": ["strike-through"],
"text": "Level 2",
"_key": "randomKey80"
}
Expand Down
Loading