feat(comments): implement reactions #5409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermanwikner
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Full Report@sanity/diff
@sanity/block-tools
@sanity/types
sanity/desk
@sanity/portable-text-editor
@sanity/mutator
@sanity/cli
@sanity/schema/_internal
@sanity/util/paths
sanity/router
@sanity/util/legacyDateFormat
@sanity/schema
sanity/structure
sanity/cli
@sanity/vision
@sanity/util/fs
sanity/_internal
sanity/_internalBrowser
@sanity/util/content
sanity
|
|
Component Testing Report Updated Jan 19, 2024 3:52 PM (UTC)
|
hermanwikner
force-pushed
the
edx-659
branch
from
7f65404 to
7269fa6
Compare
hermanwikner
force-pushed
the
edx-659
branch
from
d0c497a to
5237021
Compare
hermanwikner
force-pushed
the
edx-659
branch
from
0867838 to
6fe8f11
Compare
packages/sanity/src/structure/comments/src/hooks/use-comment-operations/removeOperation.ts
Show resolved
Hide resolved
pedrobonamin
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
This is awesome! Thanks @hermanwikner
Left a suggestion and some questions, but none are blockers.
robinpyon
approved these changes
Jan 19, 2024
juice49
pushed a commit
that referenced
this pull request
Jan 22, 2024
* feat(comments): add reaction components * dev(test-studio): add comment reactions workshop stories * feat(comments): comment reaction operation and data handling * feat(comments): add reactions to comments plugin * test(comments): utility function for merging two lists of comments * feat(comments): pass `readOnly` value to reactions * refactor(comments): simplify reaction users list * fix: force emoji-specific fonts, prefer buttons over cards, minor styling updates (#5524) * fix(comments): use `TooltipDelayGroupProvider` from ui-components --------- Co-authored-by: Robin Pyon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces reactions to the comments feature. In the first iteration, there will be a fixed set of reactions to select from, however, in future iterations, we may introduce the complete palette of reaction options. The reactions are stored in the comment document in the 'reactions' array. Each individual reaction is an object with the following properties:
_key- A unique key for the reaction. The key is constructed by combining the user ID and the short name of the reaction.shortName- The short name of the reaction. The short names follow the naming convention listed here.userId- The ID of the user who added the reaction.addedAt- The date when the reaction was added.Why is the
_optimisticStateneeded?This flag is required to ensure that reactions removed optimistically but not yet processed on the server are not displayed. This scenario arises when a user removes Reaction A and, while the API request for that removal is still processing, removes Reaction B. There is a chance that Reaction B might temporarily reappear in the UI when the updated list of reactions is received. This is because the updated list, received after the removal of Reaction A, may not yet reflect the removal of Reaction B. Consequently, Reaction B might temporarily reappear in the UI until the updated list, including the removal of Reaction B, is received.
To address this issue, we utilize the
_optimisticStateflag to track the removal or addition of reactions locally. When the server responds with an updated list of reactions, we filter out reactions marked with the_optimisticStateset to "removed." This prevents reactions that were removed optimistically but are still being processed from reappearing in the UI.What to review
Notes for release
Make it possible to react to comments