-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(facelift): create menu item StudioUI #5090
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
71d069c
to
84affba
Compare
Full Report@sanity/diff
@sanity/block-tools
sanity/desk
@sanity/portable-text-editor
@sanity/mutator
@sanity/cli
@sanity/schema/_internal
@sanity/util/paths
sanity/router
@sanity/util/legacyDateFormat
@sanity/schema
sanity/cli
@sanity/vision
@sanity/util/fs
sanity/_internal
@sanity/util/content
sanity
@sanity/types
|
Component Testing Report Updated Nov 2, 2023 4:16 PM (UTC)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pedrobonamin – left some comments, would love your thoughts here
c0ac60d
to
a119ef0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pedrobonamin, this looks great!
fdfcc3d
to
b19899e
Compare
* feat(facelift): create menu item StudioUI * fix(facelift): refactor workspace preview to use large menu item * fix(facelift): support icon right in large menu item * feat(facelift): update StudioUI Menu item props, remove size * feat(facelift): add Studio UI menu item stories * fix(tests): update snapshot
* feat(facelift): create menu item StudioUI * fix(facelift): refactor workspace preview to use large menu item * fix(facelift): support icon right in large menu item * feat(facelift): update StudioUI Menu item props, remove size * feat(facelift): add Studio UI menu item stories * fix(tests): update snapshot
* feat(facelift): create menu item StudioUI * fix(facelift): refactor workspace preview to use large menu item * fix(facelift): support icon right in large menu item * feat(facelift): update StudioUI Menu item props, remove size * feat(facelift): add Studio UI menu item stories * fix(tests): update snapshot
* feat(facelift): create menu item StudioUI * fix(facelift): refactor workspace preview to use large menu item * fix(facelift): support icon right in large menu item * feat(facelift): update StudioUI Menu item props, remove size * feat(facelift): add Studio UI menu item stories * fix(tests): update snapshot
Description
Introduces
StudioUI
menu item, adding defaults to create the menu items.Updates all the uses of menu items to use the new menu item.
Removes the need to define complex children when using menu items within the Studio.
tries to discourage the use of
children
prop for the menu item, making developers specifically opt out.What to review
renderMenuItem
prop to support custom wrappers (e.g. tooltip)Workspace
menu item continues using the old design, confirm if it should be updated or not.Notes for release
Introduces
StudioUI
menu item, adding defaults to create the menu items.