refactor(comments): colocate more compose resources

sanity-io · Feb 6, 2024 · 7492d72 · 7492d72
1 parent 67f3573
commit 7492d72
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 8 deletions.
diff --git a/packages/sanity/src/structure/comments/i18n/resources.ts b/packages/sanity/src/structure/comments/i18n/resources.ts
@@ -14,12 +14,16 @@ const commentsLocaleStrings = defineLocalesResources('comments', {
   /** The text for the button to go to the correct field */
   'button-go-to-field-aria-label': 'Go to field',
 
+  /** When composing a comment, the placeholder text shown when adding a comment to a field with no current comments */
+  'compose.add-comment-input-placeholder': 'Add comment to <strong>{{field}}</strong>',
   /** When composing a comment, the placeholder text shown when the input is empty */
   'compose.create-comment-placeholder': 'Create a new comment',
   /** When composing a comment, the aria label for the button to mention a user */
   'compose.mention-user-aria-label': 'Mention user',
   /** When composing a comment, the tooltip text for the button to mention a user */
   'compose.mention-user-tooltip': 'Mention user',
+  /** When composing a reply, the placeholder text shown when the input is empty */
+  'compose.reply-placeholder': 'Reply',
   /** When composing a comment, the aria label for the button to send a comment */
   'compose.send-comment-aria-label': 'Send comment',
   /** When composing a comment, the tooltip text for the button to send a comment */
@@ -139,11 +143,6 @@ const commentsLocaleStrings = defineLocalesResources('comments', {
   /** The comments onboarding popover header text */
   'onboarding-popover-header': 'Document fields now have comments',
 
-  /** The placeholder for creating a new comment thread for a given field */
-  'placeholder-add-comment-to-field': 'Add comment to <strong>{{field}}</strong>',
-  /** The placeholder for replying to a comment */
-  'placeholder-reply': 'Reply',
-
   /** Tooltip for the button to add a reaction to a comment */
   'reactions.add-reaction-tooltip': 'Add reaction',
   /** Aria label for the individual reactions you can choose from when reacting to a comment */

diff --git a/packages/sanity/src/structure/comments/plugin/field/CommentsFieldButton.tsx b/packages/sanity/src/structure/comments/plugin/field/CommentsFieldButton.tsx
@@ -131,7 +131,11 @@ export function CommentsFieldButton(props: CommentsFieldButtonProps) {
 
   if (!hasComments) {
     const placeholder = (
-      <Translate t={t} i18nKey="placeholder-add-comment-to-field" values={{field: fieldTitle}} />
+      <Translate
+        t={t}
+        i18nKey="compose.add-comment-input-placeholder"
+        values={{field: fieldTitle}}
+      />
     )
 
     const content = (

diff --git a/packages/sanity/src/structure/comments/src/components/list/CommentsListItem.tsx b/packages/sanity/src/structure/comments/src/components/list/CommentsListItem.tsx
@@ -334,7 +334,7 @@ export const CommentsListItem = React.memo(function CommentsListItem(props: Comm
               onDiscardConfirm={confirmDiscard}
               onKeyDown={handleInputKeyDown}
               onSubmit={handleReplySubmit}
-              placeholder={t('placeholder-reply')}
+              placeholder={t('compose.reply-placeholder')}
               readOnly={readOnly}
               ref={replyInputRef}
               value={value}

diff --git a/packages/sanity/src/structure/comments/src/components/list/CreateNewThreadInput.tsx b/packages/sanity/src/structure/comments/src/components/list/CreateNewThreadInput.tsx
@@ -76,7 +76,7 @@ export function CreateNewThreadInput(props: CreateNewThreadInputProps) {
   }, [])
 
   const placeholder = (
-    <Translate t={t} i18nKey="placeholder-add-comment-to-field" values={{field: fieldTitle}} />
+    <Translate t={t} i18nKey="compose.add-comment-input-placeholder" values={{field: fieldTitle}} />
   )
 
   return (