Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for auto-generated captions #327

Closed
slegay opened this issue Oct 16, 2023 · 3 comments
Closed

Support for auto-generated captions #327

slegay opened this issue Oct 16, 2023 · 3 comments

Comments

@slegay
Copy link

slegay commented Oct 16, 2023

Mux recently released the ability to auto-generate subtitles. The feature can only be enabled during the initial MUX API request that creates the video asset.

https://www.mux.com/blog/auto-generated-captions-for-on-demand-video-have-arrived-crowd-roars-with-applause

Describe the solution you'd like
We'd like the Mux Sanity plugin to offer an option to auto-generate captions.

Describe alternatives you've considered
We've tried adding this ourselves, but the plugin seems to make use of a server-side proxy to circumvent Mux's CORS rules that are preventing requests from browsers.

@thealice
Copy link

+1, this would be awesome.

@evankirkiles
Copy link
Contributor

evankirkiles commented Feb 12, 2024

I agree, I think this is in the hands of the Sanity team themselves to enable implementation. I also made an attempt, and it seems as if the only fields that are proxied through to Mux in new_asset_settings when creating the direct upload link are the ones the plugin explicitly provides:

  • mp4_support for specifying whether an MP4 should also be created

As that backend Sanity->Mux API proxy is not open-source, or at least I can't find its implementation anywhere, it would be a huge help to allow us to pass through additional arbitrary configuration options from the browser. At the very least, some documentation on what that endpoint /addons/mux is doing would be helpful in this plugin's README.

I have a PR enabling more fine-tune configuration of a mux.video field, e.g. by allowing specification of encoding_tier, max_resolution_tier, master_access, and more on both a plugin-wide level and on a field-specific level, but until Sanity lets these additional options through the proxy any attempts on the open-source side of things to update the plugin won't work.

While the non-nested new_asset_settings options will be simple enough to provide support for (exposing them much like mp4_support, it might take a little bit more work to enable providing or generating captions & subtitles, as these are set in the new_asset_settings input array.

@stipsan thoughts?

@hdoro
Copy link
Collaborator

hdoro commented Apr 8, 2024

This is now possible with plugin version 2.3.0 (see #350 ) ✅

@hdoro hdoro closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants