Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: manage without translations #192

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

thebiggianthead
Copy link
Contributor

This PR adds the ability to override the default of disabling the "manage translations" button when no translations exist as yet. This helps to solve scenarios where translated documents already exist but they need tying together on the metadata document.

To review:

  • Is the config name allowCreateMetaDoc OK? I'm not totally happy with it but my creativity is letting me down.
  • Test different scenarios and that the button works as expected when the option is disabled / enabled and whether the metadata doc already exists or not.

Copy link
Contributor

@SimeonGriggs SimeonGriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea and config option look fine to me. If you've tested this works as expected, then go for it.

@thebiggianthead thebiggianthead merged commit bf301c5 into main Sep 27, 2024
11 checks passed
@thebiggianthead thebiggianthead deleted the feat/manage-without-translations branch September 27, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants