Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urlopen doesn't take HTTPS #63

Open
BogdanRusu-03 opened this issue Jun 13, 2024 · 1 comment
Open

urlopen doesn't take HTTPS #63

BogdanRusu-03 opened this issue Jun 13, 2024 · 1 comment

Comments

@BogdanRusu-03
Copy link

When I try to open an MPD file from an HTTPS link, urlopen throws the following error:

urllib.error.URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self-signed certificate (_ssl.c:1007)>
parse.py:16

I would suggest the following changes in parse.py:

def parse(cls, string_or_url)  ->  **def parse(cls, string_or_url, verifiySSL=false):**
def load_xmldom(cls, string_or_url)  ->  def load_xmldom(cls, string_or_url, verifiySSL)
    ...
    mpd_string = urlopen(string_or_url).read()  -> requests.get(string_or_url, verify=verifiySSL)
    ....
@onovy
Copy link
Collaborator

onovy commented Jun 13, 2024

not verifying SSL is bad practice. Make your self-signed certificated trusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants