Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-419 - As LeGo, we would like additional fields to be added to the Study setup form in Sequencescape, so users don’t have to input data twice #4443

Open
4 tasks
harrietc52 opened this issue Oct 23, 2024 · 0 comments
Labels

Comments

@harrietc52
Copy link
Contributor

harrietc52 commented Oct 23, 2024

User story
As LeGo, we would like additional fields to be added to the Study setup form in Sequencescape, so users don’t have to input data twice (once in Sequencescape, and again in eDAM2 internal).

Currently, the Data access data is supposed to be added to the internal eDAM system, after a study has been created in Sequencescape. However, users are not always filling this is which is delaying the release of data in EGA.

Who are the primary contacts for this story
@harrietc52

Who is the nominated tester for UAT
Kalia D
Mugdha K
Anyone else?

Acceptance criteria
To be considered successful the solution must allow:

  • the list of fields from the Google Sheet are added to the Study creation form
  • specific fields show/ hide depending on another field, as specified in the Google Sheet
  • each field has a “Hint”
  • Update Liz C with the final list of fields in Sequnecscape, as she is creating a Google form with these inputs and they want to align with Sequencescape

Dependencies
This story is blocked by the following dependencies:

  • #<issue_no.>
  • sanger/#<issue_no.>

References
This story has a non-blocking relationship with:

  • #<issue_no.>
  • sanger/#<issue_no.>

Additional context
Questions

  • Is the Steps 1 & 2 in the Lucid chart correct? i.e The first time the Study is created in the eDAM2 internal system (and therefore when the DAA is created) is when the data from the study tables in the MLWH is pulled into eDAM2 internal? (OR is the Study first created first via eDAM, and then updated when data is pulled in?)
  • Is this for both “Standard” and “Non-Standard” studies? Do both Standard and Non-Standard studies follow the same process? Do both Standard and Non-Standard have the same DAA questions?
  • Currently in Sequencescape Study set up, there is a Study Name field. Is this linked to the eDAM field Study Title? Would you like the “Hint” for this field in eDAM adding to Sequencescape?
  • Currently in Sequencescape Study set up, under ENA specific questions there is a Title (study_study_title) and Study Description (study_description). Is the Study Description in eDAM different (not ENA specific), and if so, shall a new field for “Study Description" to the Sequencescape Study set up page? What would you like the text to show, and what would you like the field in MLWH to be?
  • The same field name collabs refers to both name an institution. Should these fields be seperated to collabs_name and collabs_institution?
  • There is a note in "eDAM DAA setup questions” - “Users must be able to add multiple collabs”. How would you like this to be persisted in the study table in MLWH? If there is more than one collaborator?
  • Is want_pub_delay needed? For example, could this field be removed and only the publish_delay field used, and set to 12 as default?
  • ega_dataset_accession_numbers What input is required for "Known EGA Dataset Accession numbers for this study”. What type is it? Is it required? It is missing from "eDAM DAA setup questions” Google Sheet below
  • What is the “Hint” text for each field? Please can it be added to the Google Sheet (see eDAM fields below) Do not all fields have a “Hint”?
  • Can we separate non_sanger_dac_notes into two serpate fields non_sanger_dac_name and non_sanger_dac_email?
  • Could dao_send_to_giselle and dao_send_to be combined, to just be one field dao_send_to? By default the email is datasharing@sanger, or if not, input another email? Assume email requires .ac.uk? Then don't have a users name in a field.
  • Can ez1_to_approve be removed? And sanger_approve_by become one field? Which defaults to Sarion B email, or the manually entered email? Could ez1’s address be replaces with a non-personal / role level? (incase Sarion B ever left the institute). Also, in "eDAM DAA setup questions” doc it says Display when option 1 is selected for ez1_to_approve, is this correct, or should it display when “No” is selected for ez1_to_approve?
  • In "eDAM DAA setup questions” doc it says Display when option 1 is selected for in_edam , is this correct, or should it display when “No” is selected for in_edam ?
  • Is approved_by_lego okay? A “yes”/ “No” input? Is the text description okay, or would you like anything adding? e.g. “Confirm this study has been approved by LeGo and added to eDAM2 internal”. Would you like this to be nearer the start of the form? If “No”, can the user still submit the Study in Sequencescape?
  • Would you like all these questions to be in their own group, within the Study setup page? Where exactly would you like them to go on the form (at the bottom/ top etc?)
  • Are all these questions only required if the Studies release strategy is EGA, or ENA, or Both (ie would these questions only want to appear if EGA/ENA checkbox is selected in Sequencescape set up form?)
  • Check the (red) field types in Google Sheet are appropriate

Fields to be added:
PSD Google Sheet with DAA fields

eDAM DAA setup questions

@psd-issuer psd-issuer bot changed the title As LeGo, we would like additional fields to be added to the Study setup form in Sequencescape, so users don’t have to input data twice Y24-419 - As LeGo, we would like additional fields to be added to the Study setup form in Sequencescape, so users don’t have to input data twice Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant