Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify OutPut Path or Tmp #263

Closed
Nilad opened this issue Nov 13, 2019 · 3 comments
Closed

Specify OutPut Path or Tmp #263

Nilad opened this issue Nov 13, 2019 · 3 comments

Comments

@Nilad
Copy link

Nilad commented Nov 13, 2019

I re-up this closed thread #209

I work with singularity image and the compartiment of files is a major problem. Can you add path for output file or better a tmp file path ?

Thanks in advance.

@Nilad
Copy link
Author

Nilad commented Jan 7, 2020

I see that with the -p option, i can rooted the output files if absolut path is provided.

But only one file is not rooted -> core_gene_alignment.aln.seq.joint.txt

Maybe, it could be a nice thing to make an option for an output directory in the python/gubbins/common.py script ( especialy for the files paths defines in lines 103-112).

@puethe
Copy link
Contributor

puethe commented Jan 7, 2020

Hi @Nilad ,
which version of Gubbins are you using? I remember there was an issue with the prefix not being added to all output files, but that should be fixed in the most recent version (2.4.0).
We do not really maintain Gubbins anymore, so I'm afraid that your suggestion won't be addressed any time soon, but if it's important to you feel free to submit a pull request.
Cheers,
Christoph

@Nilad
Copy link
Author

Nilad commented Jan 8, 2020

Hi @puethe,
You have right, i used a previous version 2.3.4 and now with the 2.4.0 i dont have the file root problem.

Its a good idea to make a pull request. But it will not just for an "output directory option" but more to render Gubbins containerable for Docker/Singularity.

@Nilad Nilad closed this as completed Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants