Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] onActivityResult deprecated on AndroidX #239

Closed
omarpm25 opened this issue Jul 1, 2021 · 3 comments
Closed

[BUG] onActivityResult deprecated on AndroidX #239

omarpm25 opened this issue Jul 1, 2021 · 3 comments
Labels
bug

Comments

@omarpm25
Copy link

omarpm25 commented Jul 1, 2021 •
edited
Loading

onActivityResult deprecated on AndroidX

Captura de Pantalla 2021-07-01 a la(s) 12 24 01 p m

It is necessary to migrate to the new way of obtaining the result, based on google documentation registerForActivityResult:

https://developer.android.com/training/basics/intents/result
@omarpm25 omarpm25 added the bug label Jul 1, 2021
@ynkm169
Copy link

ynkm169 commented Oct 26, 2021

This is a real problem. Could somebody take a look? It has been so long.

@ynkm169
Copy link

ynkm169 commented Nov 1, 2021

@sangcomz there is an easy fix for this.
Just take the method "override fun startAlbum()", copy it and create another function
"fun getStartAlbumIntent(): Intent". That way whoever uses it can call registerForActivityResult with that intent.

@sangcomz sangcomz mentioned this issue Jan 8, 2022
Merged
@sangcomz
Copy link
Owner

sangcomz commented Jan 8, 2022

Feature added in 1.0.0-beta01.
thanks :)

@sangcomz sangcomz closed this as completed Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ynkm169 @omarpm25 @sangcomz