Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.1 dependency #6

Open
DrillSergeant opened this issue Jul 18, 2019 · 0 comments
Open

PHP 7.1 dependency #6

DrillSergeant opened this issue Jul 18, 2019 · 0 comments

Comments

@DrillSergeant
Copy link

Hey Sandstrom guys,

I just wanted to try out v1.x of this package. As there are return type declaration of void is used (at least in Domain\Model\Content::setSource and mabye more) I cannot run it because we use Neos 3.3 with PHP 7.0.33 on our servers.

As the 1.x branch is for Neos 3.x and Neos 3.x only requires php: ~7.0 I suggest to remove that void return type declaration.

If that is not possible I suggest to at least add the PHP-version constraint to this package.

Best Regards,
Peter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant