Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Selection Action Disabled When Filters Are Present (Windows/Firefox) #930

Closed
pjcross opened this issue Jan 9, 2020 · 2 comments
Closed
Assignees

Comments

@pjcross
Copy link
Contributor

pjcross commented Jan 9, 2020

Although filtering and hide/show of selected points have conflicts in terms of determining what should be visible, pinning of selected points should be enabled during filtering. However, if a filter is present, the pinning function within 'Selection Action' is disabled. Removing the filter reenables it and the images are then retrieved.

@alexsielicki
Copy link
Collaborator

I'm enabling pinning when filtering is happening. However, you still won't be able to pin simulations that are hidden by filters, even if they are selected in the table. For example, if you have selected simulations 1 and 3, but 3 is filtered out, only 1 will be pinned.

@alexsielicki
Copy link
Collaborator

alexsielicki commented Jan 28, 2020

Also, I'm disabling (i.e., graying out) the pin item in the dropdown if there is no selection or if all items in the selection are also hidden by the current filters. Let me know if this sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants