Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Update Issues #67

Closed
tshead2 opened this issue Aug 30, 2013 · 4 comments
Closed

Multiple Update Issues #67

tshead2 opened this issue Aug 30, 2013 · 4 comments
Assignees
Labels

Comments

@tshead2
Copy link
Member

tshead2 commented Aug 30, 2013

We have at least two situations where the scatterplot is updated multiple times. These are mostly harmless when data sizes are small, but become killers when we get to 1000000 points:

  • When loading the page for the first time, the scatterplot is updated three times, once without a selected variable and twice with a selected variable, if there's a bookmark in effect.
  • When making an interactive selection in the scatterplot, the scatterplot updates itself, then notifies listeners that the selection has changed. It seems as if some listener is sending the selection back to the scatterplot, causing it to be updated twice.
@ghost ghost assigned alexsielicki Aug 30, 2013
@tshead2
Copy link
Member Author

tshead2 commented Sep 3, 2013

To reproduce the second issue:

  • Open a CCA model in Firefox, go to the Firebug console, and filter out all but Info messages.
  • Click a row in the data table => observe a single "render selection" and "render" message.
  • Click a point in the scatterplot => "render selection" and "render" messages appear twice. This shouldn't happen.

@pjcross
Copy link
Contributor

pjcross commented Sep 17, 2013

I just posted an issue about the wave form plot flashing. This sounds like a similar issue, since I'm guessing the flash is the wave form drawing with nothing selected. Given how slow the waveform drawing is, removing the extra cycle would make sense (I labeled it an enhancement, but maybe I should have called it a bug).

@tshead2
Copy link
Member Author

tshead2 commented Sep 17, 2013

Not sure whether this is the same issue or not, I'm only looking at multiple updates in CCA at the moment, because they're low-hanging fruit.

@tshead2
Copy link
Member Author

tshead2 commented Sep 18, 2013

Refactored the CCA model page and components and eliminated several sources of multiple updates.

@tshead2 tshead2 closed this as completed Sep 18, 2013
@ghost ghost assigned tshead2 Sep 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants