Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle NaNs properly from the web UI. #66

Closed
tshead2 opened this issue Aug 28, 2013 · 0 comments
Closed

Handle NaNs properly from the web UI. #66

tshead2 opened this issue Aug 28, 2013 · 0 comments
Assignees
Labels

Comments

@tshead2
Copy link
Member

tshead2 commented Aug 28, 2013

Currently, we assume that there are no NaNs in the input or output columns when computing a CCA model, and our push scripts / CCA UI enforce this behavior. NaNs in ignored columns are fine, so it is possible to import data containing NaNs, if they're in ignored columns. However, this means that if a user re-runs a model and uses a column containing NaNs, the computation will fail.

We really ought to be filtering NaNs out of the data when we compute the model, so it doesn't matter whether the uploaded data contains them or not. However, this raises an issue with the final visualization, in that we can no longer assume a one-to-one mapping between rows in the raw data and points in the scatterplot.

@ghost ghost assigned tshead2 Aug 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant