Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support general cores in TTENSOR #61

Closed
Tracked by #173
ntjohnson1 opened this issue Feb 25, 2023 · 2 comments
Closed
Tracked by #173

Support general cores in TTENSOR #61

ntjohnson1 opened this issue Feb 25, 2023 · 2 comments
Assignees
Labels
capability New capability/functionality doing Actively being worked on
Milestone

Comments

@ntjohnson1
Copy link
Collaborator

This added ttensor support for dense cores. MATLAB supports any core that follows an interface. We can probably use protocols and mypy to sanity check this. Alternatively may consider creating a base class for some shared pyttb tensor functionality.

@dmdunla dmdunla added this to the v2.0 milestone Mar 16, 2023
@dmdunla dmdunla added the capability New capability/functionality label Mar 16, 2023
@DeepBlockDeepak
Copy link
Collaborator

Leaving note here to highlight issue #147 's Core Type Conversion note, and Nick's response to it. The Ktensor.ipynb will need to be updated accordingly, once this this core issue is resolved.

@ntjohnson1 ntjohnson1 added the doing Actively being worked on label Jul 3, 2023
@ntjohnson1
Copy link
Collaborator Author

MATLAB states generic cores are supported but special cases tensors and sptensor. For the scope of this ticket only adding support to sptensor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
capability New capability/functionality doing Actively being worked on
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants