Skip to content
This repository has been archived by the owner on Apr 30, 2018. It is now read-only.

Progress not reporting due to iframe element not having a data-progress attribute. #22

Open
benATvia opened this issue Jan 29, 2015 · 1 comment

Comments

@benATvia
Copy link

I am unable to receive progress events using the stock setup as described on your site - I've narrowed it down to the following in the onPlayProgress function:

if (!iframeEl.data('progress')) {
      return;
    }

I have confirmed I am receiving progress information from the data variable.

I don't see anywhere in the Vimeo docs or in your code that indicates when that iframe would have a progress data attribute.

Thanks - and great work!

@williamjulianvicary
Copy link

I removed that block of code as I feel it's unnecessary and it was also breaking this functionality for me, haven't seen any negative impact this has had on functionality - not sure why this would be used over the data attribute that is passed.

I'd remove it (my pull request has done so also)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants