Add ability to update connection params after connect #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sandeepmistry, take a look when you get a chance.
I ran into an issue when using Web Bluetooth with Google Chrome, where after a few messages Chrome would send a connection params update to change the connection interval to a very slow 97.5 ms, which is too slow for my application. After that happens if I change them back to what I have them set at for new connections, Chrome accepts it and doesn't mess with it any further.
This PR adds two things, ability to update the connection params during an active connection, and a new event so you can detect when the connection params are changed by the central.