Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate Deadlocks on nRF5 #184

Open
dsanders11 opened this issue Sep 10, 2017 · 0 comments · May be fixed by #202
Open

Indicate Deadlocks on nRF5 #184

dsanders11 opened this issue Sep 10, 2017 · 0 comments · May be fixed by #202

Comments

@dsanders11
Copy link
Contributor

Indications will deadlock on nRF5 after N indications without any other activity. This is because the current code incorrectly considers indications to use one of the TX buffers, and they never get replenished because there is no BLE_EVT_TX_COMPLETE.

Per documentation for the SoftDevices (S110, S130, S132) indications do not consume an application buffer, so they shouldn't be involved in the TX buffer tracking.

I have a fix in my repo (e611775) but I didn't open a PR because nRF8 needs to be checked for the same issue, and I think more changes should be made to updateCharacteristicValue, like checking the return value of sd_ble_gatts_hvx for the possible error conditions.

@sandeepmistry sandeepmistry linked a pull request Nov 13, 2017 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant