Add S.reverse #220
Add S.reverse #220
Conversation
| //# reverse :: [a] -> [a] | ||
| //. | ||
| //. Takes an array and returns an array of the its elements in | ||
| //. reversed order. |
There was a problem hiding this comment.
Let's make it clear that this function is not Array-specific. I suggest:
Returns the elements of the given list in reverse order.
|
@davidchambers sorry it took me so long. As for the implementation: I also added a check for |
| {}, | ||
| [List(a), List(a)], | ||
| function reverse(xs) { | ||
| var result = []; |
There was a problem hiding this comment.
⬅️ ⬅️ Two spaces for indentation, please. :)
gilligan
force-pushed
the
add-reverse
branch
5 times, most recently
from
9e6a539 to
07e1ca6
Compare
| [List(a), List(a)], | ||
| function reverse(xs) { | ||
| var result = []; | ||
| if (_type(xs) === 'String') return reverse(xs.split('')).join(''); |
There was a problem hiding this comment.
Let's switch the two lines above. result is unused in the String case.
There was a problem hiding this comment.
No problem - I just usually put it on top since it does not matter anyhow because of variable hoisting. I'll move it.
|
Thanks for the updates, Tobi. LGTM aside from the two minor stylistic issues I mentioned above. :) |
|
🌳 |
Fixes #196