Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document required node version in CONTRIBUTING.md #248

Closed
rjmk opened this issue Sep 2, 2016 · 2 comments
Closed

Document required node version in CONTRIBUTING.md #248

rjmk opened this issue Sep 2, 2016 · 2 comments

Comments

@rjmk
Copy link
Contributor

rjmk commented Sep 2, 2016

The doctest for

> S.encaseEither(S.I, JSON.parse, '[')
Left(new SyntaxError('Unexpected end of input'))

will break as JSON.parse's error message changed at some point between node 4 and node 6 to "Unexpected end of JSON input"

We should document which node versions can be used by people developing the library

@davidchambers
Copy link
Member

How do you feel about this now that #250 has been merged, @rjmk?

@rjmk
Copy link
Contributor Author

rjmk commented Sep 8, 2016

Much better solution!

@rjmk rjmk closed this as completed Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants