Converts collection in spec/features/collection_type_spec.rb and highlights bug.

[bwatson78]

Fixes

Fixes spec/features/collection_type_spec.rb.

Summary

Converts collection in spec/features/collection_type_spec.rb and highlights bug.

Type of change (for release notes)

• notes-valkyrie Valkyrie Progress

Changes proposed in this pull request:

• L#244: Changes collection object to :pcdm_collection because the query used to find a collection_type's collections is tied to Hyrax::PcdmCollection, which :hyrax_collection doesn't parse to when that type of collection is created via FactoryBot.
• L#300+: split this into ActiveFedora vs. Valkyrie to highlight bug detailed in BUG: In Koppie, a collection type can be deleted when it has collections associated to it. #6611. I also believe this is tied to the behavior discussed above (CollectionResource vs. Hyrax::PcdmCollection for querying).
• All: refactored to shorten test suite's length.

@samvera/hyrax-code-reviewers