Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valkyrization: Mark persist_directly_contained_output_file_service_spec.rb as ActiveFedora only #6594

Conversation

abelemlih
Copy link
Contributor

Fixes

Mark persist_directly_contained_output_file_service_spec.rb as ActiveFedora only, since Valkyrized applications rely on app/services/hyrax/valkyrie_persist_derivatives.rb, as shown in app/models/concerns/hyrax/file_set/derivatives.rb:

Hydra::Derivatives.source_file_service = Hyrax::LocalFileService
Hydra::Derivatives.output_file_service = Hyrax::ValkyriePersistDerivatives
# Hydra::Derivatives::FullTextExtract.output_file_service = Hyrax::PersistDirectlyContainedOutputFileService
Hydra::Derivatives::FullTextExtract.output_file_service = Hyrax::ValkyriePersistDerivatives

Type of change (for release notes)

  • notes-valkyrie Valkyrie Progress

Changes proposed in this pull request:

  • Mark persist_directly_contained_output_file_service_spec.rb as ActiveFedora only.

@samvera/hyrax-code-reviewers

@abelemlih abelemlih added valkyrization notes-valkyrie Release Notes: Valkyrie specific labels Jan 9, 2024
@abelemlih abelemlih self-assigned this Jan 9, 2024
@dlpierce dlpierce merged commit c3c753a into main Jan 9, 2024
4 checks passed
@dlpierce dlpierce deleted the abel-fix_persist_directly_contained_output_file_service_spec.rb branch January 9, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-valkyrie Release Notes: Valkyrie specific valkyrization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants