Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valkyrization: Fix failing tests in admin_set_member_service_spec.rb #6492

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Valkyrization: Fix failing tests in admin_set_member_service_spec.rb #6492

merged 1 commit into from
Dec 1, 2023

Conversation

abelemlih
Copy link
Contributor

Fixes

Fix failing tests in spec/services/hyrax/admin_set_member_service_spec.rb for Koppie

Type of change (for release notes)

  • notes-valkyrie Valkyrie Progress

Changes proposed in this pull request:

  • Use valkyrie_create to create the admin set and works in the tests

@samvera/hyrax-code-reviewers

@abelemlih abelemlih added valkyrization notes-valkyrie Release Notes: Valkyrie specific labels Dec 1, 2023
@abelemlih abelemlih self-assigned this Dec 1, 2023
@dlpierce dlpierce merged commit 77e95d3 into main Dec 1, 2023
4 checks passed
@dlpierce dlpierce deleted the abel-fix_admin_set_member_service_spec branch December 1, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlpierce dlpierce dlpierce approved these changes

Assignees

@abelemlih abelemlih

Labels
notes-valkyrie Release Notes: Valkyrie specific valkyrization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abelemlih @dlpierce