Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates find_works_search_builder to allow for both id strings as well as Valkyrie id objects. #6460

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Updates find_works_search_builder to allow for both id strings as well as Valkyrie id objects. #6460

merged 2 commits into from
Nov 27, 2023

Conversation

bwatson78
Copy link
Contributor

Fixes

Fixes app/search_builders/hyrax/my/find_works_search_builder.rb and associated rSpec.

Summary

Updates find_works_search_builder to allow for both id strings as well as Valkyrie id objects.

Type of change (for release notes)

  • notes-valkyrie Valkyrie Progress

Changes proposed in this pull request:

  • app/search_builders/hyrax/my/find_works_search_builder.rb: ensures that ids that are passed in are processed as strings when building searches.
  • spec/search_builders/hyrax/my/find_works_search_builder_spec.rb: updates testing to Valkyrie objects and removes ActiveFedora-specific SolrQueryBuilders.

@samvera/hyrax-code-reviewers

@bwatson78 bwatson78 added valkyrization notes-valkyrie Release Notes: Valkyrie specific labels Nov 20, 2023
@bwatson78 bwatson78 self-assigned this Nov 20, 2023
@bwatson78 bwatson78 force-pushed the updates_find_works_search_builder_spec branch from b47ceca to 76e2e9f Compare November 20, 2023 19:33
dlpierce
dlpierce approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@dlpierce dlpierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like to_s would work well enough, but I'll accept this too.

@dlpierce dlpierce merged commit e8366ea into main Nov 27, 2023
4 checks passed
@dlpierce dlpierce deleted the updates_find_works_search_builder_spec branch November 27, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlpierce dlpierce dlpierce approved these changes

Assignees

@bwatson78 bwatson78

Labels
notes-valkyrie Release Notes: Valkyrie specific valkyrization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bwatson78 @dlpierce