Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Valkyrie base view specs #6344

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Fix Valkyrie base view specs #6344

merged 3 commits into from
Oct 10, 2023

Conversation

dlpierce
Copy link
Contributor

@dlpierce dlpierce commented Oct 6, 2023

Fixes

Fixes #6307

Summary

Fixes all failing koppie specs in spec/views/hyrax/base

Changes proposed in this pull request:

  • To match existing specs, resource model human names are now titleized
  • The work id is explicitly converted to a string in case it was a Valkyrie::ID

@samvera/hyrax-code-reviewers

@dlpierce dlpierce added the notes-valkyrie Release Notes: Valkyrie specific label Oct 6, 2023
@dlpierce dlpierce merged commit ef530d7 into main Oct 10, 2023
@dlpierce dlpierce deleted the valk_base_view_specs branch October 10, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwatson78 bwatson78 bwatson78 approved these changes

Assignees
No one assigned
Labels
notes-valkyrie Release Notes: Valkyrie specific
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Koppie specs: spec.views.hyrax.base._form_metadata uninitialized constant Hyrax::GenericWorkForm
2 participants
@dlpierce @bwatson78