refactor Hyrax::LeaseHelper specs to work under koppie #6197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunn
previously approved these changes
Aug 25, 2023
no-reply
force-pushed
the
lease-helper-spec
branch
from
596a24f
to
9281dc0
Compare
|
seems like this wants my attention, still. one of the tests is failing, which i'm surprised by |
some of these tests ensure interactions with AF models, these can be disabled. others needed to be refactored to use Valkyrie for setup.
dlpierce
force-pushed
the
lease-helper-spec
branch
from
9281dc0
to
0aa76e9
Compare
tpendragon
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some of these tests ensure interactions with AF models, these can be disabled.
others needed to be refactored to use Valkyrie for setup.