Set geonames usernames using environment variable

[eliotjordan]

Fixes

Closes #5799 Closes #5800

Summary

Make geonames username configurable with environment variable.

Guidance for testing, such as acceptance criteria or new user interface behaviors:

• To test locally, set docker-compose GEONAMES_USERNAME environment variable to valid user name
• To test in QA, set GEONAMES_USERNAME environment variable to valid user name

Type of change (for release notes)

• notes-minor New Features that are backward compatible

@samvera/hyrax-code-reviewers

[eliotjordan]

@dlpierce To test this in nurax pg, someone will have to set an ENV var to the existing geonames username.

[dlpierce]

Suggested change

- GEONAMES_USERNAME=username

Let's not set a (likely unusable) default here.

[eliotjordan]

I think having a placeholder is a good idea for local development. Knowing where to put the value seems useful The application behaves the same way with a dummy value vs. no value. Perhaps changing it to your_geonames_username?

If the consensus is to remove it, I'll do it.

[eliotjordan]

@dlpierce I update the dummy GEONAMES_USERNAME value as described above. Thoughts? Still remove this from docker-compose?

[no-reply]

i'm generally negative on dummy values in configuration and, at least last time i was up-to-date, hyrax doesn't include them in general.

ultimately i'm fine either way, but if there's going to be a dummy value, i'd think it should go in the .env, rather than the docker-compose?

[eliotjordan]

I'll remove it and update https://github.com/samvera/hyrax/wiki/Hyrax-Management-Guide#geonames unless there's some other place that this should be documented.

[eliotjordan]

Config removed from docker-compose files.

[eliotjordan]

I'll update the wiki once this work is merged.

[dlpierce]

I've added a dedicated geonames account to CircleCI's ENV config.